Post by thread:16f84 macro error

To read the MPASM help file, this should work: s_out macro somebyte movlw somebyte endm Given that macro, can someone tell me why I get this error: Error[124] C:\PROGRA~1\MPLAB\SEROUT.ASM 20 : Illegal argument (expected single character) Error[108] C:\PROGRA~1\MPLAB\SEROUT.ASM 20 : Illegal character (×) FYI: Line 20 is the second line in the above macro.

At 12:09 PM 3/29/00 +1000, you wrote: > The term "somebyte" is to be a single character eg "i" or"j" or"k" etc This is the help file example (which works): cfl_jge macro file, con, jump_to movlw con & 0xff subwf file, w btfsc status, carry goto jump_to endm I have tried (as you suggested): s_out macro s movlw s endm and (to copy their examples): s_out macro con movlw con endm and: s_out macro con movlw con & 0xff endm and: s_out macro file movlw file endm and several other variations. Exact same error. Above all of this is: ERRORLEVEL -302 Processor 16F84 Radix HEX include <p16f84.inc> __config _XT_OSC & _WDT_OFF & _PWRTE_ON cblock H'0c' AA,BB ;looping regs MYBYTE,BITCNT ;sendbyte temp endc jb >Dennis > > > > >> {Original Message removed}

JB <spam_OUTPICLISTTakeThisOuTMITVMA.MIT.EDU> wrote: > s_out macro somebyte > movlw somebyte > endm > > Given that macro, can someone tell me why I get this error: > > Error[124] C:\PROGRA~1\MPLAB\SEROUT.ASM 20 : Illegal argument > (expected single character) and Plunkett, Dennis <.....PICLISTKILLspam@spam@MITVMA.MIT.EDU> replied: > The term "somebyte" is to be a single character which JB misunderstood: > I have tried (as you suggested): > > s_out macro s > movlw s > endm JB: What Dennis meant is that when you USE the macro, you have to give it a single character. It doesn't matter whether the macro variable is called "s" or "somebyte"; the important thing is that DOWN BELOW, when you say "s_out x", the "x" has to be a single character. In other words, this won't work: s_out "hello" but these will: s_out 5 s_out 'a' s_out (5+3)/2 -Andy === Andrew Warren - fastfwdKILLspamix.netcom.com === Fast Forward Engineering - San Diego, California === http://www.geocities.com/SiliconValley/2499

> but these will: > > s_out 5 > s_out 'a' > s_out (5+3)/2 > Maybe on your machine :) The second example: s_out 'a' is exactly what I was using to "call" it. The actual macro (before stripping it down to nothingness for diagnostic testing) was like so: s_out macro thebyte movlw thebyte call sendbyte endm then invoke it like this: s_out 'G' s_out 'o' s_out 'o' s_out 'd' s_out ' ' s_out 'd' s_out 'o' s_out 'g' s_out 'g' s_out 'y' s_out H'0d' s_out H'0a' If I follow what you're saying, then it works for you, but not for me. I'm using MPLAB 4.12 - could that be a problem here? It's sure a mystery, but if it doesn't work, then so be it. It's not a big deal - just frustrating that something I've used for years (in other assembly languages) doesn't work as expected and especially maddening that the help file doesn't...help. My instincts tell me it's one of those really obvious things that I'm missing, but I just don't see it. No doubt it'll hit me one day when I least expect it. Thanks for the help thus far. JB > {Original Message removed}

jb wrote: > > then invoke it like this: > > s_out 'G' > s_out 'o' > s_out 'o' > s_out 'd' > s_out ' ' > s_out 'd' > s_out 'o' > s_out 'g' > s_out 'g' > s_out 'y' > s_out H'0d' > s_out H'0a' > Try it like this - who knows, maybe it'll work :-) s_out 'h' s_out 'e' s_out 'l' s_out 'l' s_out 'o' s_out ' ' s_out 'w' s_out 'o' s_out 'r' s_out 'l' s_out 'd' s_out H'0d' s_out H'0a'

jb <.....PICLISTKILLspam.....MITVMA.MIT.EDU> wrote: > s_out 'a' > > is exactly what I was using to "call" it. JB: Uh... Are you SURE? As I recall, one of the error messages that you said that MPASM generated was "Illegal Character 'x'"... Might you have been trying to do something like "s_out 0x0D"? If so, try representing that carriage-return as 00DH or H'0D' and see if that works. Also... There was an issue with single- and double-quotes in some versions of MPASM; if you WERE just doing "s_out 'a'", try s_out "a" instead. -Andy === Andrew Warren - EraseMEfastfwdspam_OUTTakeThisOuTix.netcom.com === Fast Forward Engineering - San Diego, California === http://www.geocities.com/SiliconValley/2499

part 0 1618 bytes Again, This is what I get: Building SEROUT.ASM... Command line: "C:\PROGRA~1\MPLAB\MPASMWIN.EXE /e+ /l+ /c+ /p16F84 /q SEROUT.ASM" Warning[224] C:\PROGRA~1\MPLAB\SEROUT.ASM 28 : Use of this instruction is not recommended. Warning[224] C:\PROGRA~1\MPLAB\SEROUT.ASM 30 : Use of this instruction is not recommended. Error[124] C:\PROGRA~1\MPLAB\SEROUT.ASM 14 : Illegal argument (expected single character) Error[108] C:\PROGRA~1\MPLAB\SEROUT.ASM 14 : Illegal character (×) MPLAB is unable to find output file "SEROUT.hex". Build failed. > {Original Message removed}

jb <PICLISTspam_OUTMITVMA.MIT.EDU> wrote: > Okay, I've now tried this at two computers, both with 4.12, both give > me the same errors. File attached if anyone feels like running it > through. I tried as Andrew suggested, using the double-quotes, but it > didn't make a difference. JB: Glad you finally attached the file. Your problem is in the line marked with a "<<<<<<<<": s_out "G" s_out 'o' s_out 'o' s_out 'd' s_out '' <<<<<<<<<< s_out 'D' s_out 'o' s_out 'g' You need a space in there; it should read: s_out ' ' -Andy === Andrew Warren - @spam@fastfwdKILLspamix.netcom.com === Fast Forward Engineering - San Diego, California === http://www.geocities.com/SiliconValley/2499

Insert a space in between the two '' next to each other. On Wed, 29 Mar 2000 12:21:17 -0700 jb <KILLspamjbKILLspamCI.GLENWOOD-SPRINGS.CO.US> writes: {Quote hidden}> Okay, I've now tried this at two computers, both with 4.12, both give > me > the same errors. File attached if anyone feels like running it > through. I > tried as Andrew suggested, using the double-quotes, but it didn't > make a > difference. > > Again, This is what I get: > > Building SEROUT.ASM... > > Command line: "C:\PROGRA~1\MPLAB\MPASMWIN.EXE /e+ /l+ /c+ /p16F84 > /q > SEROUT.ASM" > Warning[224] C:\PROGRA~1\MPLAB\SEROUT.ASM 28 : Use of this > instruction is > not recommended. > Warning[224] C:\PROGRA~1\MPLAB\SEROUT.ASM 30 : Use of this > instruction is > not recommended. > Error[124] C:\PROGRA~1\MPLAB\SEROUT.ASM 14 : Illegal argument > (expected > single character) > Error[108] C:\PROGRA~1\MPLAB\SEROUT.ASM 14 : Illegal character (W) > > MPLAB is unable to find output file "SEROUT.hex". > > Build failed. > > > > > {Original Message removed}

When in doubt, look in the .lst file. In this case, you will see that the error appears immediately after the line that caused it. However, I will guess that it is your use of '' rather than ' ' for a space. -- Rich On Wed, 29 Mar 2000, jb wrote: {Quote hidden}> Date: Wed, 29 Mar 2000 12:21:17 -0700 > From: jb <RemoveMEjbTakeThisOuTCI.GLENWOOD-SPRINGS.CO.US> > Reply-To: pic microcontroller discussion list <spamBeGonePICLISTspamBeGoneMITVMA.MIT.EDU> > To: TakeThisOuTPICLISTEraseMEspam_OUTMITVMA.MIT.EDU > Subject: Re: 16f84 macro error > > Okay, I've now tried this at two computers, both with 4.12, both give me > the same errors. File attached if anyone feels like running it through. I > tried as Andrew suggested, using the double-quotes, but it didn't make a > difference. > > Again, This is what I get: > > Building SEROUT.ASM... > > Command line: "C:\PROGRA~1\MPLAB\MPASMWIN.EXE /e+ /l+ /c+ /p16F84 /q > SEROUT.ASM" > Warning[224] C:\PROGRA~1\MPLAB\SEROUT.ASM 28 : Use of this instruction is > not recommended. > Warning[224] C:\PROGRA~1\MPLAB\SEROUT.ASM 30 : Use of this instruction is > not recommended. > Error[124] C:\PROGRA~1\MPLAB\SEROUT.ASM 14 : Illegal argument (expected > single character) > Error[108] C:\PROGRA~1\MPLAB\SEROUT.ASM 14 : Illegal character (×) > > MPLAB is unable to find output file "SEROUT.hex".

Well, I was right about one thing - it *was* something obvious.. Frankly, I thought there was a space in there - just the way it looked at 1280/1024. Time to either drop my resolution or get glasses. Many, many, thanks for the help! I owe somebody lunch - if you're ever headed through Glenwood Springs, CO, drop me an e-mail. Wow.. > {Original Message removed}