Post by thread:[OT]: Jal: A patch

part 1 603 bytes content-type:TEXT/PLAIN; charset=US-ASCII Hi, I would like to say that jal now works here and that I found a small mistake. Jal would make output files named .asm and .hex if the source contained any '.'s before the filename (as in ../src/myjal.jal). The attached humble patch fixes this. Please put it wherever jal patches live (I do not know where they live). The jal.c compiler is very impressive (the way it is written). Did you really write it all by hand, Wouter ? thanks, Peter -- http://www.piclist.com hint: PICList Posts must start with ONE topic: [PIC]:,[SX]:,[AVR]: ->uP ONLY! [EE]:,[OT]: ->Other [BUY]:,[AD]: ->Ads part 2 1646 bytes content-type:TEXT/PLAIN; charset=US-ASCII; name="jal-0453-diff1-plp-2003-02-01.patch" (decoded base64) *** ../jal.c Sat Feb 1 13:06:45 2003 --- jal.c Sun Feb 2 00:26:26 2003 *************** *** 20,27 **** */ ! char jal_version[] = "00.04-53"; ! /********** external stuff **********/ --- 20,26 ---- */ ! char jal_version[] = "00.04-53-pl1"; /********** external stuff **********/ *************** *** 61,67 **** #endif #endif - /********** global things **********/ /* for lack of a build-in boolean... */ --- 60,65 ---- *************** *** 804,819 **** } /* replace '.' with '\0' */ void chop_extension( char *s ){ stack_guard; ! for( ; *s != '\0'; s++ ){ ! if( *s == '.' ) *s = '\0'; ! } } void chop_path( char *s ){ char *p, *q; stack_guard; q = s; for( p = s; *p != '\0' ; p++ ){ if( *p == directory_separator ) q = p + 1; --- 802,832 ---- } /* replace '.' with '\0' */ + /* rather replace *last* '.' with \0 unless we see a directory_separator first, + * while searching backwards - plp 2003-2-1 */ void chop_extension( char *s ){ + char *q; + int l; + stack_guard; ! ! if((l = strlen(s) - 1) < 1) ! return; /* point to last char */ ! q = s + l; ! do { ! if(*q == '.') { ! *q = '\0'; ! break; ! } ! if(*q == directory_separator) /* only this OS's - plp */ ! break; ! } while(--q >= s); } void chop_path( char *s ){ char *p, *q; stack_guard; + q = s; for( p = s; *p != '\0' ; p++ ){ if( *p == directory_separator ) q = p + 1; part 3 2 bytes -

> The jal.c compiler is very impressive (the way it is written). Did you > really write it all by hand, Wouter ? Yes, is there any other way to write source? If I had written it using some tool I would have GPL'ed the input to that tool, not the output. Wouter van Ooijen -- ------------------------------------------- Van Ooijen Technische Informatica: http://www.voti.nl consultancy, development, PICmicro products -- http://www.piclist.com hint: The list server can filter out subtopics (like ads or off topics) for you. See http://www.piclist.com/#topics

On Sun, Feb 02, 2003 at 01:14:13PM +0100, Wouter van Ooijen wrote: > > The jal.c compiler is very impressive (the way it is written). Did you > > really write it all by hand, Wouter ? > > Yes, is there any other way to write source? If I had written it using > some tool I would have GPL'ed the input to that tool, not the output. You wouldn't have to do either of course as using a GPL tool doesn't attach any license restrictions to its input or its output. There was a time when bison attempted to GPL its output. But then the developers got a clue. BAJ -- http://www.piclist.com hint: The list server can filter out subtopics (like ads or off topics) for you. See http://www.piclist.com/#topics

On Sun, 2 Feb 2003, Wouter van Ooijen wrote: *>> The jal.c compiler is very impressive (the way it is written). Did you *>> really write it all by hand, Wouter ? *> *>Yes, is there any other way to write source? If I had written it using ;-) *>some tool I would have GPL'ed the input to that tool, not the output. I am impressed by the way it is written but I think that it is very hard to maintain at least for an outsider like me. I also made it SIGSEGV using the dump/debug options (source was wisp628.jal). Never mind, it's a great free tool for whoever needs it. Peter -- http://www.piclist.com hint: The list server can filter out subtopics (like ads or off topics) for you. See http://www.piclist.com/#topics

> I think that it is very hard > to maintain at least for an outsider like me. I agree. reasons: 1. it was written to be maintainable by me, fitting my writing style and nothing else 2. it was originally written for 16c84 only, after which it has been 'streched' to cover 12-bit cores, other 14-bot cores and even 16-bit cores. Wouter van Ooijen -- ------------------------------------------- Van Ooijen Technische Informatica: http://www.voti.nl consultancy, development, PICmicro products -- http://www.piclist.com hint: The PICList is archived three different ways. See http://www.piclist.com/#archives for details.

> I think that it is very hard to maintain at least for an outsider like me. The GPL release of the JAL compiler raises a bunch of questions about open source software that I hadn't thought of before, mostly along the lines of what sort of changes you're interested in accepting from "the community." For instance, the monolithic nature of the current source makes me think that there would be any number of people thinking "hey, all I have to do is break this up into reasonably sized modules, and I can add 'made extensive changes to open source JAL compiler' to my resume." Some of these people might be capable of doing a reasonable job, but it becomes really fuzzy as to whether this is the sort of change that Wouter would be willing to accept back... BillW -- http://www.piclist.com hint: The PICList is archived three different ways. See http://www.piclist.com/#archives for details.

> as to whether this is the sort of change that Wouter would be willing > to accept back... One of the interesting aspects of open source is the legal versus 'recognised' ownership of the code. Do read the CAB book (not just the essay) on forking etc. Legally I have no special right with respect to the source (except that the original source is still mine, so I can use it without adhereing to GPL, but that is for the original source only, not for any modifications). I GPL'ed jal.c because I have little time to do with it what should be done, so I if anyone stands up and says 'I maintain a Jal code base, please give me your changes' I will applaud (and give him my changes!). Wouter van Ooijen -- ------------------------------------------- Van Ooijen Technische Informatica: http://www.voti.nl consultancy, development, PICmicro products -- http://www.piclist.com hint: The PICList is archived three different ways. See http://www.piclist.com/#archives for details.